Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xzgv - A GTK+/Imlib-based picture viewer for X https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244702 ------- Additional Comments From kevin@xxxxxxxxx 2007-06-20 02:22 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e392277f1447076402df2e3d9e782cb2 xzgv-0.8.tar.gz e392277f1447076402df2e3d9e782cb2 xzgv-0.8.tar.gz.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: See below - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. You might add "|| :" to the end of your install-info calls. See:http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db 2. Might add AUTHORS and NEWS as doc files? 3. You should use %{?_smp_mflags} with your make call unless it doesn't work. If it doesn't please add a comment that it's not being used. 4. You seem to be missing a BuildRequires: desktop-file-utils Which causes the build to fail. Adding that gets it working. 5. The "Application" Categories in your desktop file is no longer used. It should be removed. See: http://standards.freedesktop.org/menu-spec/latest/apa.html 6. Is redhat-graphics an appropriate icon for this app? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review