https://bugzilla.redhat.com/show_bug.cgi?id=1295217 --- Comment #30 from Denis Fateyev <denis@xxxxxxxxxxx> --- (In reply to Roman Tsisyk from comment #29) > > 2) Though I'm not really insisting, but pointing out full BRs is according the current guidelines. As pointed above, you should also add `make` and `coreutils`; > > I see that even core packages ignores this practice. It's a recent invention, so many packages just don't have these changes for historical reasons. Generally speaking, there are tons of packages in pkgdb that don't fully comply with current guidelines and will probably never be (intricate/superfluous buildroot tags, buildroot cleanup, %clean section, %license missing, etc. deprecated stuff), but new packages should certainly follow the current guidelines. > I'm just curious do I need a dependency on kernel? :) I'll update my spec > anyway, but I have no idea how to check BR on the base system. Well, it's quite simple: along build deps, you just add deps on things that are used through your package spec (make for `make`, coreutils for `mv`, `install`, `mkdir`, etc.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review