https://bugzilla.redhat.com/show_bug.cgi?id=1295217 --- Comment #29 from Roman Tsisyk <roman@xxxxxxxxxx> --- > 1) Please use "install -Dpm 0644 doc/man/man3/msgpuck.h.3* %{buildroot}%{_mandir}/man3/" instead of "cp -f" to preserve files timestamps; Good catch. Thanks! > 2) Though I'm not really insisting, but pointing out full BRs is according the current guidelines. As pointed above, you should also add `make` and `coreutils`; I see that even core packages ignores this practice. I'm just curious do I need a dependency on kernel? :) I'll update my spec anyway, but I have no idea how to check BR on the base system. > 3) Changelog list will shortly become messy, e.g. during the next mass rebuild by rel-eng: they'll add a changelog entry with an empty line in the end making the whole list ragged. As also pointed above, it would better to use an empty line as the changelog items delimiter. OK, I'll take this into account too. Probably I need to learn some more examples from http://pkgs.fedoraproject.org/. I'll update my spec tomorrow and push. I hope that is it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review