[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #16 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
> I can't import "github.com/projectatomic/oci-register-machine" with the devel
> package installed -- I get a 'import "github.com/projectatomic/oci-register-machine"
> is a program, not an importable package' error.  Were the reusable bits
> supposed to be broken out into an oci-register-machine package and called
> from main()?  If so, then the compiler won't accept "oci-register-machine"
> as a package name, and this will affect the Provides: in the devel package.

Sally, if the devel subpackage will contain only files with 'package main'
directive, nothing from the subpackage can not be imported. Either set
with_devel to 0 or break oci-register-machine.go into to files so there is at
least one file with 'package oci-register-machine' directive.

> If %{with_bundled} is set to 1, it'll lose the BuildRequires: on
> golang(github.com/godbus/dbus), and it isn't carrying a vendored copy,
> so the build would fail.

This is useful for future use when vendor or Godeps directory are present. At
the current state it does not make sense to set with_bundled to 1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]