https://bugzilla.redhat.com/show_bug.cgi?id=1282903 Nalin Dahyabhai <nalin@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #15 from Nalin Dahyabhai <nalin@xxxxxxxxxx> --- fedora-review hit its own bug #1264803, but a manual check shows that the package installation succeeds. We've got some issues around being able to use the -devel package's contents when building other packages; the rest of the notes cover things which I think will be pretty straightforward to tweak. Please let me know if I need to elaborate on anything or provide assistance. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines Manual check succeeds, so ignore this issue. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. License is ASL 2.0, links only with BSD golang-github-godbus-dbus-devel [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /misc/register/review-oci-register- machine/licensecheck.txt ASL 2.0 [x]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/libexec/docker, /usr/share/gocode, /usr/share/gocode/src/github.com Might need to add Requires: on docker for /usr/libexec/docker. /usr/share/gocode/src and /usr/share/gocode/src/github.com are owned by golang, which should be fine. /usr/libexec/docker/hooks.d probably needs to be provided by multiple packages if docker isn't going to. /usr/share/gocode/src/github.com/projectatomic probably needs to be provided by multiple packages, so it's fine. [!]: %build honors applicable compiler flags or justifies otherwise. The Makefile doesn't pick up $LDFLAGS from the environment. Per /usr/lib/rpm/macros.d/macros.golang-compiler, Fedora 24 defines gobuild() as: go build -compiler gc -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n')" -a -v -x If the makefile's going to run the compiler, it may want to pick up some of this. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. Version tag on the changelog entry doesn't match the version of the package, but that's easily fixed. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package The source for the man page isn't really devel documentation; I think it can be dropped from the -devel package. I can't import "github.com/projectatomic/oci-register-machine" with the devel package installed -- I get a 'import "github.com/projectatomic/oci-register-machine" is a program, not an importable package' error. Were the reusable bits supposed to be broken out into an oci-register-machine package and called from main()? If so, then the compiler won't accept "oci-register-machine" as a package name, and this will affect the Provides: in the devel package. [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). The makefile hard-codes the location where the man page is installed. If the Makefile defines a MANDIR variable, we can override it to follow %{_mandir} during the %install phase. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. It could stand to have a longer %description, but otherwise it's fine. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. If %{with_bundled} is set to 1, it'll lose the BuildRequires: on golang(github.com/godbus/dbus), and it isn't carrying a vendored copy, so the build would fail. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oci- register-machine-devel , oci-register-machine-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. Installed files are generated at build-time. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.14 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.14 INFO: Mock Version: 1.2.14 Finish: chroot init INFO: installing package(s): /misc/register/review-oci-register-machine/results/oci-register-machine-0-0.1.git1e10ae0.fc24.x86_64.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-devel-0-0.1.git1e10ae0.fc24.noarch.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-debuginfo-0-0.1.git1e10ae0.fc24.x86_64.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-debuginfo-0-0.1.git1e10ae0.fc24.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 --setopt=deltarpm=false install /misc/register/review-oci-register-machine/results/oci-register-machine-0-0.1.git1e10ae0.fc24.x86_64.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-devel-0-0.1.git1e10ae0.fc24.noarch.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-debuginfo-0-0.1.git1e10ae0.fc24.x86_64.rpm /misc/register/review-oci-register-machine/results/oci-register-machine-debuginfo-0-0.1.git1e10ae0.fc24.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: oci-register-machine-0-0.1.git1e10ae0.fc24.x86_64.rpm oci-register-machine-devel-0-0.1.git1e10ae0.fc24.noarch.rpm oci-register-machine-debuginfo-0-0.1.git1e10ae0.fc24.x86_64.rpm oci-register-machine-0-0.1.git1e10ae0.fc24.src.rpm oci-register-machine.x86_64: W: spelling-error Summary(en_US) Golang -> Golan, Golan g, Angolan oci-register-machine.x86_64: W: spelling-error Summary(en_US) systemd -> systems, system, system d oci-register-machine.x86_64: W: spelling-error %description -l en_US Golang -> Golan, Golan g, Angolan oci-register-machine.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d oci-register-machine.x86_64: W: incoherent-version-in-changelog 0-0.1.git6863 ['0-0.1.git1e10ae0.fc24', '0-0.1.git1e10ae0'] oci-register-machine-devel.noarch: W: spelling-error Summary(en_US) Golang -> Golan, Golan g, Angolan oci-register-machine-devel.noarch: W: spelling-error Summary(en_US) systemd -> systems, system, system d oci-register-machine-devel.noarch: W: spelling-error %description -l en_US Golang -> Golan, Golan g, Angolan oci-register-machine-devel.noarch: W: spelling-error %description -l en_US systemd -> systems, system, system d oci-register-machine-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub oci-register-machine.src: W: spelling-error Summary(en_US) Golang -> Golan, Golan g, Angolan oci-register-machine.src: W: spelling-error Summary(en_US) systemd -> systems, system, system d oci-register-machine.src: W: spelling-error %description -l en_US Golang -> Golan, Golan g, Angolan oci-register-machine.src: W: spelling-error %description -l en_US systemd -> systems, system, system d 4 packages and 0 specfiles checked; 0 errors, 14 warnings. Requires -------- oci-register-machine-devel (rpmlib, GLIBC filtered): oci-register-machine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) oci-register-machine-debuginfo (rpmlib, GLIBC filtered): Provides -------- oci-register-machine-devel: golang(github.com/projectatomic/oci-register-machine) oci-register-machine-devel oci-register-machine: oci-register-machine oci-register-machine(x86-64) oci-register-machine-debuginfo: oci-register-machine-debuginfo oci-register-machine-debuginfo(x86-64) Source checksums ---------------- https://github.com/projectatomic/oci-register-machine/archive/1e10ae06d1849c730a9e8eb9f9b7fdafe8d68b6e/oci-register-machine-1e10ae0.tar.gz : CHECKSUM(SHA256) this package : fa72b92306f8a0adf8106bd648228879df7d0a3aeecc21a76f053c5472640333 CHECKSUM(SHA256) upstream package : fa72b92306f8a0adf8106bd648228879df7d0a3aeecc21a76f053c5472640333 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n oci-register-machine Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review