https://bugzilla.redhat.com/show_bug.cgi?id=1295217 --- Comment #21 from Denis Fateyev <denis@xxxxxxxxxxx> --- (In reply to Roman Tsisyk from comment #20) > > 2) If you use only rhel7 and above, you can drop "%{!?_licensedir" workaround (I don't see the el6 branch requested); > > Yeah, I know about latest %license changes in EPEL7. Is it possible to keep > this workaround? I don't want to maintain a separate version of spec for > RHEL6/CentOS6. If you're going to maintain el6, then better keep this workaround. At least, until the situation with recently introduced `%license` support in el6 is settled. > I can add `BuildRequires: gcc`, it is not a problem. I'd recommend you adding all of them. It won't break things. > >> 4) You can save on '%cmake' options if you use the default options that are > >> already bootstrapped in epel7 and fXX branches: > >> $ rpm -E '%cmake' > >> ... > >> /usr/bin/cmake \ > >> -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \ > >> -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \ > >> -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \ > >> -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ > >> -DCMAKE_INSTALL_PREFIX:PATH=/usr \ > >> -DINCLUDE_INSTALL_DIR:PATH=/usr/include \ > >> -DLIB_INSTALL_DIR:PATH=/usr/lib64 \ > >> ... > >> You may use them in `msgpuck` instead of CMAKE_INSTALL_LIBDIR and > >> CMAKE_INSTALL_INCLUDEDIR; > > GNUInstallDirs.cmake from CMake doesn't work well with `%cmake` default > defines. I have no idea why %cmake macro uses LIB_INSTALL_DIR instead of > CMAKE_INSTALL_LIBDIR. I think either cmake package or %cmake macro should be > fixed instead. I can file a ticket, if you agree with me. Well, I'm not really aware of GNUInstallDirs.cmake issue if it's exist. You can get more details from `cmake` maintainer first or asking in the list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review