https://bugzilla.redhat.com/show_bug.cgi?id=1295217 --- Comment #20 from Roman Tsisyk <roman@xxxxxxxxxx> --- > (In reply to Roman Tsisyk from comment #16) > > Is it possible to run the same automated tests before pushing to master? If you submit an update then a bunch of tests are run automatically by Taskotron and they should catch that. > 1) Specfile has invalid name, it shouldn't contain the package version: I renamed msgpuck.spec to msgpuck-1.0.1.spec because it was suggested by rpmlint or fedora-review :) I'll fix this problem today. Sorry. > 2) If you use only rhel7 and above, you can drop "%{!?_licensedir" workaround (I don't see the el6 branch requested); Yeah, I know about latest %license changes in EPEL7. Is it possible to keep this workaround? I don't want to maintain a separate version of spec for RHEL6/CentOS6. > fedora-review is wrong here, and one SHOULD have BuildRequires:gcc, > though things work just fine without, and will do so for the forseeable > future. The spec file is correct. I can add `BuildRequires: gcc`, it is not a problem. >> 4) You can save on '%cmake' options if you use the default options that are >> already bootstrapped in epel7 and fXX branches: >> $ rpm -E '%cmake' >> ... >> /usr/bin/cmake \ >> -DCMAKE_C_FLAGS_RELEASE:STRING="-DNDEBUG" \ >> -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG" \ >> -DCMAKE_Fortran_FLAGS_RELEASE:STRING="-DNDEBUG" \ >> -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \ >> -DCMAKE_INSTALL_PREFIX:PATH=/usr \ >> -DINCLUDE_INSTALL_DIR:PATH=/usr/include \ >> -DLIB_INSTALL_DIR:PATH=/usr/lib64 \ >> ... >> You may use them in `msgpuck` instead of CMAKE_INSTALL_LIBDIR and >> CMAKE_INSTALL_INCLUDEDIR; GNUInstallDirs.cmake from CMake doesn't work well with `%cmake` default defines. I have no idea why %cmake macro uses LIB_INSTALL_DIR instead of CMAKE_INSTALL_LIBDIR. I think either cmake package or %cmake macro should be fixed instead. I can file a ticket, if you agree with me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review