Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Geo-METAR - Perl module for accessing aviation weather information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242901 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-20 00:29 EST ------- The test suite uses perl(Test) but that's currently provided by the base perl package. I've no idea if the plan is to keep it there or not. It would be technically correct to add a build dependency on perl(Test), but I don't think it's required and everything certainly runs fine without it. Review: * source files match upstream: 200cddda40f51b58405aadf8fa69d259d8fe0651831ac0b63706db1174b12701 Geo-METAR-1.14.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Geo::METAR) = 1.14 perl-Geo-METAR = 1.14-2.fc8 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=1, Tests=6, 0 wallclock secs ( 0.03 cusr + 0.02 csys = 0.05 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review