Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hunspell-ar - Arabic word list/dictionaries for OpenOffice https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212984 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2007-06-20 00:26 EST ------- OK - Package meets naming and packaging guidelines See below - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 28c3b7dce962051d55b23ac5e51f264b ./buckwalter_morphan_1_hunspell_patch.tar.gz 28c3b7dce962051d55b23ac5e51f264b ./buckwalter_morphan_1_hunspell_patch.tar.gz.1 b3ccdcacb32e57e2653f3e16de707a3e ./buckwalter2unicode.py b3ccdcacb32e57e2653f3e16de707a3e ./buckwalter2unicode.py.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The base source file doesn't match this package name, but it matches up with the other hunspell dicts, so this is not an issue. 2. I was thinking the version didn't look right, but after checking the possible options I think this will be ok, at least I can't see any better option with the way upstream names releases. So, no blockers I can see, so this is re-APPROVED. Sorry for the delay and detour here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review