[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #10 from Ville Skyttä <ville.skytta@xxxxxx> ---
I'm not at all convinced that it's related to the JDK platform vendor. Our
OpenJDK also reports itself as "vendor: Oracle Corporation" so it might be
pretty much the same as the one upstream is using.

You did not tell upstream that you've changed xbean-finder-shaded to
xbean-finder and org.apache.xbean.asm5 to org.objectweb.asm. That is crucial
information. I hacked your SRPM so that it does not do those changes and
instead downloads xbean-finder-shaded from the network and uses it during the
build, and all tests pass. So the failures are related to that change.

I don't agree with you that stuff like this is not a blocker. It is quite clear
that the package does not work properly at the moment. Because the failures are
in the processor component which is quite central to this one and it would not
make sense to try shipping the package without it, I don't think this package
should be shipped at all before the issues are resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]