[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #9 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Ville Skyttä from comment #4)
> Test stuff is a blocker. First, now there is some kind of an explanation for
> the FinderTest failure, but there's no explanation why it is fine to just
> disable the test; the failure seems to be directly related to the
> xbean-finder dependency changes made in the package. Either the code needs
> to be fixed so that the test passes, or the test fixed if it's that and not
> the code that is broken after the change. Can't simply change the dep and
> ignore errors resulting from doing so.
> 
> Second, on a quick look, CleanProcessorTest and WeaveProcessorTest failures
> do not seem to have anything to do with the xbean stuff, so there's still no
> explanation for why it would be ok to ignore the failures.

Seem relate to JDK platform vendor. I'm waiting for some news related
https://issues.apache.org/jira/browse/WEAVER-10. This kind of issues usually
happen and should not considering as blocker, IMO.

> Regarding crosslinking, I'm just looking at the contents of the -javadoc
> package; there are various links in them to the online Java SE 6 javadoc.
> For local crosslinking, adding build deps on related *-javadoc packages and
> then pointing the javadoc plugin to appropriate local
> file:///usr/share/javadoc/* dirs would fix it, I imagine (at least it was
> something like that back when I last had anything to do with Java
> packaging).
> https://maven.apache.org/plugins/maven-javadoc-plugin/examples/links-
> configuration.html (non-blocker as I don't think there is a requirement to
> do this, but I do recommend fixing it as it should be quite easy)
Done
> The following subpackages seem to be missing license files: example,
> normalizer, normalizer-example, privilizer-api
Done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]