https://bugzilla.redhat.com/show_bug.cgi?id=1297281 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Link Dupont from comment #5) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > > "cp %{SOURCE1} ." can be replaced with "-a1" argument to %autosetup. > > The -a# tries to uncompress the source. In this case, my %SOURCE1 is not a > compressed file. It's just XML. I could compress it so that "-a1" works, but > that felt like more work on my part to maintain changes to the appdata.xml. I didn't know that. cp is fine of course. > > - Package installs a %{name}.desktop using desktop-file-install or desktop- > > file-validate if there is such a file. > > Was there a change that needed to be made from this recommendation? Does the > SConstruct not install via desktop-file-install? OK, I missed that, so it's not necessary ... > I added a call to desktop-file-validate in %check ... but doing it explicitly is probably better. > > You should also call appstream-util validate-relax --nonet on the appstream > > file in %check. You should also manually call appstream-util validate by > > hand, and fix the issues it reports. This is more strict, so you don't want > > to use it in %check: > > > > /usr/share/appdata/endless-sky.appdata.xml: FAILED: > > • tag-missing : <update_contact> is not present > > • style-invalid : <caption> is too long [Finding trade routes, made > > easy: the map view shows commodity prices for other star systems and can > > color them based on price, to help you decide what trade goods you should > > buy in the current system for sale elsewhere] > > • style-invalid : <caption> is too long [Strange discoveries await > > you beyond the boundaries of known space] > > • style-invalid : <caption> is too long [You can earn a living just > > by buying commodities for a low price in one star system and selling them at > > a profit elsewhere] > > • style-invalid : <developer_name> is too long [XXX: Insert Company > > or Developer Name] > > Validation of files failed > > > > Fixed all that up and got some better screenshots. ... > Has the appdata spec changed in rawhide? Maybe, it changes all the time ;) The litmus test is whether gnome-software shows it. On my F23 machine it didn't want to show the previous version, but it shows this one, and it looks great. + latest version + license is acceptable for Fedora + license files are present, %license is used + latest version + builds, installs, runs OK + has appdata and desktop files + scriptlets look sane + provides and requires are OK Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review