[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #7 from Link Dupont <link@xxxxxxxxxxxx> ---
(In reply to Link Dupont from comment #5)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> > - Package installs a %{name}.desktop using desktop-file-install or desktop-
> >   file-validate if there is such a file.
> 
> Was there a change that needed to be made from this recommendation? Does the
> SConstruct not install via desktop-file-install?

I added a call to desktop-file-validate in %check

> http://copr.fedoraproject.org/coprs/linkdupont/fedora-link-extras/build/
> 154038/
> 
> 
> copr build failed when building in rawhide.
> 
> > + appstream-util validate-relax --nonet /builddir/build/SOURCES/endless-sky.appdata.xml
> > /builddir/build/SOURCES/endless-sky.appdata.xml: GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will not be saved or shared with other applications.
> > FAILED:
> > ? tag-invalid           : <project_group> is not valid [none]
> > Validation of files failed
> 
> Has the appdata spec changed in rawhide?

Looks like <project_group> is optional, so I removed it from the appdata.xml.

Latest koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12588229
Updated SPEC:
https://fedorapeople.org/cgit/linkdupont/public_git/packages.git/plain/SPECS/endless-sky.spec
Updated SRPM:
https://linkdupont.fedorapeople.org/srpms/endless-sky-0.8.10-5.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]