https://bugzilla.redhat.com/show_bug.cgi?id=1284527 --- Comment #21 from Dan Horák <dan@xxxxxxxx> --- sorry for the delay, but formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 080a0992dc4241ac0c8c2b7e556a20bbb45d068d skiboot-5.1.11.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (ASL-2.0). License text included in package. OK* latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK package builds in mock (Rawhide/ppc64 + ppc64le). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. BAD correct systemd scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - was up-to-date when updating the review ticket, please update to 5.1.12 for the next iteration - distro-wide CFLAGS are not used, try setting CFLAGS="%{optflags}" for the make call in %build, see https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags - my scratch build = http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3077491 - please update the scriptlets and Requires to the current style, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review