https://bugzilla.redhat.com/show_bug.cgi?id=1244678 James Hogarth <james.hogarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@xxxxxxxxx --- Comment #5 from James Hogarth <james.hogarth@xxxxxxxxx> --- I'd say libbloom and libxxhash realistically should be packaged separately and then this blocked against those... Note that btrfs-progs-devel includes rbtree.h ... you might try building against that (though I've not had a chance to check the exposed functions yet) ... It might be better to have pkgconfig(glib-2.0) and pkgconfig(sqlite3) in the BR instead of naming the packages specifically. Rather than naming SBINDIR and MANDIR specifically you can just pass PREFIX=%{_prefix} in to the %make_install Especially given how few files there are (only 8 including the man pages) I'd specifically list them rather than doing general globs of %{_mandir} and %{_sbindir} to avoid accidents in capturing too much during packaging. Note that there is a csum-test which can be used to check the algorithm is being used correctly ... adding a %check to the spec file with something akin to this appears to work building against an F23 mock of the git master: %check dd if=/dev/urandom of=4kfilerand count=1 bs=4096 tgt_hash="$(sha256sum ./4kfilerand)" [[ "$(./csum-test -b 1024 --hash=sha256 ./4kfilerand | grep 4kfilerand)" == "${tgt_hash}" ]] [[ "$(./csum-test -b 4096 --hash=sha256 ./4kfilerand | grep 4kfilerand)" == "${tgt_hash}" ]] Note there are dedup patches being proposed for 4.5 on the btrfs mailing list at the moment so it's not actually clear if this particular tool has a future anyway if btrfs-progs gets an actual dedup subcommand... I've sent a mail into the list to get clarification on this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review