https://bugzilla.redhat.com/show_bug.cgi?id=1269844 --- Comment #11 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Orion Poplawski from comment #10) > - doc subpackage must include the license Fixed. I thought it caused problems with the same file in different packages, but it seems not. > - Note license breakdown in spec Comment added. > [!]: Uses parallel make %{?_smp_mflags} macro. I commented that it's useless. > - Apparently doesn't cause a problem, but Provides should use "=" not "==". Fixed, ta. I wish there was proper documentation for rpm specs. Spec URL: https://loveshack.fedorapeople.org/review/jcuber.spec SRPM URL: https://loveshack.fedorapeople.org/review/jcuber-4.3.3-2.el6.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review