https://bugzilla.redhat.com/show_bug.cgi?id=1293100 --- Comment #18 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Roman Tsisyk from comment #17) > > %defattr(-,root,root,-) is unnecessary [https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions]. It seems defattr in only needed in RHEL <= 4. > > Requires: systemd-units → systemd-units has been merged into systemd for a long while > > I found these lines in postgresql package during looking for > systemd-tmpfiles example. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd for the authoritative version. Requiring systemd-units doesn't hurt, but shouldn't be added in new packages. > > Requires: tarantool = %{version} → Requires: tarantool%{?_isa} = %{version}-%{release} > > OK, I've just found that this {?_isa} is also mentioned in the guidelines. Well, sometimes you need it, sometimes not. First rule is that %{_isa} is only defined for arched packages, so noarch packages cannot really have arched dependencies. Second rule is that in general -devel packages should use %{_isa} in the dependency on the main package. The most obvious reason is that they contain a symlink %{_libdir}/*.so to %{_libdir}/*.so.x.y.z, and %{_libdir} depends on the architecture, so the architecture of the -devel subpackage and the main subpackage must match. > > Summary: Common files, admin tools and init scripts. → > > Summary: Common files and admin tools for %{name} (no dot) > > Sorry, I remember that this was mentioned in the guidelines, but I've added > this dot unintentionally. No biggie. I'm sure this guideline is violated in numerous places. > > OK, packaging is looking mostly OK. Now we get to the hard stuff :( > > A new version systemd unit files requires some amount of work, so I've > opened a ticket in upstream to track this feature [1] > [1] https://github.com/tarantool/tarantool/issues/1264 > > > What about msgpuck? It seems that you split it out for review in #1295217? > Shouldn't it be a dependency? And lua-fun? > > It should, but if I'm not mistaken, a new spec should not depend on packages > which haven't accepted to the repository yet. No, there's no such rule. Just put the other packages in "Depends on" for this one. > BTW, msgpuck and lua-fun are standalone libraries and are used by other > projects. For instance, luafun is even more popular on GitHub than tarantool > itself, because suited for more broader audience. Of course, I'll add > dependencies to these packages after finishing with them. > > I hope we will deal with systemd soon. Great. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review