https://bugzilla.redhat.com/show_bug.cgi?id=1293100 --- Comment #17 from Roman Tsisyk <roman@xxxxxxxxxx> --- > %defattr(-,root,root,-) is unnecessary [https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions]. OK, I hope it won't break RHEL/CentOS 6/7. Probably I should drop backward-compatibility code and make a separate spec file for Fedora. > Requires: systemd-units → systemd-units has been merged into systemd for a long while I found these lines in postgresql package during looking for systemd-tmpfiles example. > Requires: tarantool = %{version} → Requires: tarantool%{?_isa} = %{version}-%{release} OK, I've just found that this {?_isa} is also mentioned in the guidelines. > Summary: Common files, admin tools and init scripts. → > Summary: Common files and admin tools for %{name} (no dot) Sorry, I remember that this was mentioned in the guidelines, but I've added this dot unintentionally. > Requires: tarantool → Requires: tarantool = %{version}-%{release} OK. > %if 0%{?fedora} >= 21 %license %{_datadir}/doc/tarantool/LICENSE %else %doc %{_datadir}/doc/tarantool/LICENSE %endif → %{!?_licensedir:%global license %doc} %doc LICENSE (see https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag) OK, thanks for the advice. The problems above are very easy to fix and I will do it a little bit later. > OK, packaging is looking mostly OK. Now we get to the hard stuff :( A new version systemd unit files requires some amount of work, so I've opened a ticket in upstream to track this feature [1] [1] https://github.com/tarantool/tarantool/issues/1264 > What about msgpuck? It seems that you split it out for review in #1295217? > Shouldn't it be a dependency? And lua-fun? It should, but if I'm not mistaken, a new spec should not depend on packages which haven't accepted to the repository yet. BTW, msgpuck and lua-fun are standalone libraries and are used by other projects. For instance, luafun is even more popular on GitHub than tarantool itself, because suited for more broader audience. Of course, I'll add dependencies to these packages after finishing with them. I hope we will deal with systemd soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review