https://bugzilla.redhat.com/show_bug.cgi?id=1295075 Randy Barlow <rbarlow@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jeremy@xxxxxxxxxx | |) --- Comment #9 from Randy Barlow <rbarlow@xxxxxxxxxx> --- Package Review ============== There are two problems with the package, but only one is a blocker. See below. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [!]: Package functions as described. Notes: ejabberd still doesn't think this is the right package. Here is some output from rpmbuild: DEBUG: is_app_available, looking for App p1_cache_tab with Path "/home/rbarlow/rpmbuild/BUILD/ejabberd-15.11/deps/p1_cache_tab" DEBUG: Directory expected to be an app dir, but it doesn't exist (yet?): /home/rbarlow/rpmbuild/BUILD/ejabberd-15.11/deps/p1_cache_tab DEBUG: is_app_available, looking for App p1_cache_tab with Path "/usr/lib64/erlang/lib/p1_cache_tab-1.0.1" WARN: /usr/lib64/erlang/lib/p1_cache_tab-1.0.1/ebin/cache_tab.app has application id cache_tab; expected p1_cache_tab I'm not sure what the best course of action here is. It seems that upstream has created a confusing situation because ejabberd wants it to be called p1_cache_tab, but they've named the package cache_tab. Perhaps we should write their mailing list about it? In the meantime, this was included in the "SHOULD" section by fedora-review, but since it pertains to the name of this package which is difficult to change once it is included in Fedora, I've moved it to the MUST section. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/rbarlow/1295075-erlang- p1_cache_tab/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== rbarlow-review: [!]: I noticed that you have a check block, but the upstream source didn't look like it has unit tests. Did I miss something? If not, I suggest dropping it an removing the BuildRequires on eunit. Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-p1_cache_tab-1.0.1-3.fc24.x86_64.rpm erlang-p1_cache_tab-1.0.1-3.fc24.src.rpm erlang-p1_cache_tab.x86_64: E: no-binary erlang-p1_cache_tab.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory erlang-p1_cache_tab.x86_64: E: no-binary erlang-p1_cache_tab.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- erlang-p1_cache_tab (rpmlib, GLIBC filtered): erlang-erts erlang-p1_utils Provides -------- erlang-p1_cache_tab: erlang-p1_cache_tab erlang-p1_cache_tab(x86-64) Source checksums ---------------- https://github.com/processone/cache_tab/archive/1.0.1.tar.gz : CHECKSUM(SHA256) this package : 752b649f695e9f2777efd6b2d8dfdcc1f435104b4e363f5f0454b99fd009015c CHECKSUM(SHA256) upstream package : 752b649f695e9f2777efd6b2d8dfdcc1f435104b4e363f5f0454b99fd009015c Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1295075 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review