[Bug 1279175] Review Request: innoextract - Tool to extract installers created by Inno Setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1279175



--- Comment #11 from Hans de Goede <hdegoede@xxxxxxxxxx> ---
Hi Alexandre,

I just noticed that your .spec has:

Release:   3

instead of:

Release:   3%{?dist}

This is against the guidelines, and more importantly causes problems when
sharing the spec between releases (which is advisable). Can you please bump the
release to 4%{?dist}, add a matching changelog entry and then build ?

This will give you a: innoextract-1.5-4.fc24 build.

Usually new packages are also introduced in currently supported releases in
Fedora, I believe it would be good to bring innoextract to at least Fedora 23,
to do this switch to the f23 branch, merge it with master and then push and
build:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Update_Your_Branches_.28if_desired.29

This will give you a innoextract-1.5-4.fc23 build, this is where the %{?dist}
comes into play, the 2 release fields differing will ensure that users get the
f24 build (which may use a different compiler, lib versions etc) when upgrading
to 24.

Once you've done a f23 build, it will not appear in the repos automatically,
you will need to create an update for it as described here:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Submit_Package_as_Update_in_Bodhi

Also see:

https://fedoraproject.org/wiki/Package_update_HOWTO#Later_Branched_and_stable_releases

Regards,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]