[Bug 1295127] Review Request: awscli - Universal Command Line Environment for AWS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1295127



--- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Fabio Alessandro Locati from comment #4)
> Thanks Andrea,
> just few comments now and then tomorrow morning I'll work on the spec itself.
> 
> 1. Ok, I'll do this way, thanks
> 
> 2. This package does not provide any library, only binaries so (as for
> http://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin,
> "If the executables provide the same functionality independent of whether
> they are run on top of Python 2 or Python 3, then only one version of the
> executable should be packaged.") I think only one version should be packaged
> 
> 3. See point 2

I'm not totally sure; I'm not a Python expert, but I see awcli file in /usr/bin
as is made with your package contains a Python3 shebang (indeed, your package
builds only a Python3 awscli in Fedora).

When you will split awscli in python2-awscli and python3-awscli, it will need
two different awscli in /usr/bin, one for Python2 and one for Python3.

> 
> 4. Technically, AWSCLI does not require bash nor zsh so they should not be a
> dependency. Those helpers are used only if AWSCLI is used with BASH or ZSH.
> This is a common thing in fact even if you do not have zsh installed (as in
> my computer) that folder is present
> 

They may be packaged separately so, as 'awscli-bash-completion' and
'awscli-zsh'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]