[Bug 1292209] Review Request: python-nsdf - Support library for the Neuroscience Simulation Data Format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1292209



--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to William Moreno from comment #10)
> Did you check your koji build?
> 
> Your are using many python3 conditionals but you do not define what does
> this conditional means so you are only building a python2 subpackage.
Yes, this is on purpose. Upstream only supports python2, package needs porting
to python3. There's *was* a macro at the top of the spec file '%global
with_python3 0', but without any comment. I added the comment now, and opened
an issue upstream: https://github.com/nsdf/nsdf/issues/42.

> You can get the license file from upstream:
> https://github.com/nsdf/nsdf/blob/master/LICENSE
Yes, they merged my pull request yesterday ;)

> Open a issue upstream requesting to include the LICENSE text in the tarball,
> you can patch the license file so GLPv3 requires to provide a copy of the
> license text.
Already done and merged:
https://github.com/nsdf/nsdf/commit/466c2a3f3ada

(In reply to William Moreno from comment #11)
> Package Review
> ==============
> [!]: License file installed when any subpackage combination is installed.
Should be fixed now.

Thanks for the review!

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-nsdf.spec
SRPM URL:
https://in.waw.pl/~zbyszek/fedora/python-nsdf-0.0-2.git9621ced.fc24.src.rpm

* Fri Jan  8 2016 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> -
0.0-2.git9621ced
- Update to latest git snapshot
- Add LICENSE to %%files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]