https://bugzilla.redhat.com/show_bug.cgi?id=1294704 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- (In reply to Ville Skyttä from comment #4) > Summary and %description should say "Python 3" because this is Python 3 only. > > Summary and %description for the binary package should probably say "Python > %{python3_version}" instead of "Python 3". The name of the package "python3X-setuptools" will be displayed next to summaries and description and I think makes this point. > Group tags should go away. Gone. > with_check deserves a comment why it's not on by default. For now I think > it's because pytest and mock are not available yet, but still. Added in a bootstrap flag. > %with_check and %build_wheel would be better implemented using the standard > %bcond_with/out. Perhaps, but I'm going to stick with staying closer to the Fedora setuptools package here. > pip3 in %install should probably be made more specific. > pip-%{python3_version}? Looks like probably pip%{python3_version}. > psfl.txt and zpl.txt should be %license, not %doc. > > What is the source for psfl.txt and zpl.txt? > > psfl.txt talks about Python 2.1.1. Should it be updated to something newer? I've done so. And added ASL 2.0 since there appear to be some files under that license. It's a bit of a mess and there is an upstream issue with no response: https://bitbucket.org/pypa/setuptools/issues/132/missing-license > Rest of the docs would be better installed as "%doc docs/*" to avoid one > unnecessary dir. Fixed. > /usr/lib/python3.4/site-packages/setuptools/command/easy_install.py has a > wrong shebang, "/usr/bin/env python". I believe /usr/bin/env should not be > used in the first place for system installed stuff like this, and "python" > should probably be "python%{python3_version}" or "%{__python3}" Removed the unneeded shbang. Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python3-setuptools-19.2-2.el7.src.rpm * Wed Dec 29 2015 Orion Poplawski <orion@xxxxxxxxxxxxx> - 19.2-2 - Drop group tag - Add bootstrap conditional - Use specific pip version - Use %%license - Update license and license source - Strip unneeded shbangs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review