https://bugzilla.redhat.com/show_bug.cgi?id=1294704 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx Flags| |fedora-review? --- Comment #4 from Ville Skyttä <ville.skytta@xxxxxx> --- Summary and %description should say "Python 3" because this is Python 3 only. Summary and %description for the binary package should probably say "Python %{python3_version}" instead of "Python 3". Group tags should go away. with_check deserves a comment why it's not on by default. For now I think it's because pytest and mock are not available yet, but still. %with_check and %build_wheel would be better implemented using the standard %bcond_with/out. pip3 in %install should probably be made more specific. pip-%{python3_version}? psfl.txt and zpl.txt should be %license, not %doc. What is the source for psfl.txt and zpl.txt? psfl.txt talks about Python 2.1.1. Should it be updated to something newer? Rest of the docs would be better installed as "%doc docs/*" to avoid one unnecessary dir. /usr/lib/python3.4/site-packages/setuptools/command/easy_install.py has a wrong shebang, "/usr/bin/env python". I believe /usr/bin/env should not be used in the first place for system installed stuff like this, and "python" should probably be "python%{python3_version}" or "%{__python3}" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review