https://bugzilla.redhat.com/show_bug.cgi?id=1293735 --- Comment #6 from Dmitry Mikhirev <mikhirev@xxxxxxxxx> --- An unofficial review. Need to be fixed: * Error opening pdf file: cannot find boomagamerger. * Cups backend and filter directories are %{_prefix}/lib/cups/{backend,filter}, not %{_libdir}/cups/{backend,filter}. * Directories under %{_datadir}/icons/hicolor must not be owned by this package. * %post and %preun scripts are inconsistent: %post # Install the printer to cups backends if [ $1 = 1 ]; then sh %{_datadir}/%{name}/scripts/installPrinter.sh fi %preun # Uninstall the printer lpadmin -x "Boomaga" The printer will be removed on package update. Use 'if [ $1 = 0 ]' in %preun. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review