[Bug 1293735] Review Request: boomaga - A virtual printer for viewing a document before printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1293735



--- Comment #5 from MartinKG <mgansser@xxxxxxxx> ---
(In reply to Sergio Monteiro Basto from comment #2)
> (In reply to MartinKG from comment #0)
> I run fedora-review -b 1293735 -x CheckOwnDirs I got a review for
> boomaga-0.7.1-1, before you update to 0.7.1-2
> 
> [!]: update-mime-database is invoked in %post and %postun if package stores
>      mime configuration in /usr/share/mime/packages.
>      Note: mimeinfo files in: boomaga
>      See:
>      http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo

this part is already in the spec file, it's unclear for me, what i have to do ?

%post
# Install the printer to cups backends
if [ $1 = 1 ]; then
  sh %{_datadir}/%{name}/scripts/installPrinter.sh
fi
/bin/touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
/bin/touch --no-create %{_datadir}/mime/packages &> /dev/null || :
/usr/bin/update-desktop-database &> /dev/null || :

%postun
/usr/bin/update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    /bin/touch --no-create %{_datadir}/mime/packages &>/dev/null
    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
    /usr/bin/update-mime-database %{_datadir}/mime &> /dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
/usr/bin/update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || :


> 
> sh: /usr/bin/python: No such file or directory
> 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> I think you need check python guideline and prepare the package for python3
> as default [1] 
> 
> I recently have review [2] python-gammu maybe you may follow it , it is very
> simple all almost done with 2 or 3 macros 
> 
> [1] https://fedoraproject.org/wiki/Packaging:Python
> 
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=1234654
> 
> but I haven't much time

I 'am do not understanding, why the package needs python ? and it's totally
unclear for me what i have to change in the spec file ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]