https://bugzilla.redhat.com/show_bug.cgi?id=1282893 --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to marcindulak from comment #8) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Hm, what does this do?: > > > > %if 0%{?el6} > > %global mpich mpich > > %global mpich_load %_mpich_load > > %global mpich_unload %_mpich_unload > > %else > > %global mpich mpich > > %global mpich_load %_mpich_load > > %global mpich_unload %_mpich_unload > > %endif > > > > this is a legacy part when there was mpich2 on el6 and mpich on Fedora. > I removed that global variables. > > > > > Requires are normally written with one =. I think == might be misinterpreted. > > OK > > > > > You can replace the calls to `basename ${f}` with ${f%/*}, makes things > > slightly shorter and more readable. > > let's keep the simple basename. I'm not a fan of shortcuts. > > > > > Please use pushd/popd instead of cd/cd -. This is recommended because the > > path is printed, which makes logs easier to understand. > > > > OK > > > %defattr(-,root,root,-) is not needed. > > i believe fedora-review complains if %defattr(-,root,root,-) is missing Quite the opposite ;) Anyway the authoritative source is https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions, which says that they are not required. > > Use %{!?_licensedir:%global license %doc} and then you don't need > > conditionals in %files. > > > > this works for me when defining this global *after* the License field. > Apparently License is confused with license if global defined on the top of > the spec: > http://koji.fedoraproject.org/koji/getfile?taskID=12125886&name=build. > log&offset=-4000 Right. > > Can you comment on the reason for multiple source tarballs? Are they always > > released together? > > I would like we clarify two things: > > 1. the source includes L. Peter Deutsch md5 implementation. I think gromacs > RPM > also includes this md5 (src/external/tng_io/src/lib/md5.c) so we are fine? > > 2. quantum-espresso bundles a small part (a couple of files) belonging to > http://www.tddft.org/programs/octopus/wiki/index.php/Libxc > This is described in this commit message: > http://qe-forge.org/gf/project/q-e/scmsvn/ > ?action=ScmCommitDetail&scm_commit_id=16950 > > I have made an additional change: set ExclusiveArch due to openblas-devel. > > Spec URL: > https://marcindulak.fedorapeople.org/packages/quantum-espresso/r02/quantum- > espresso.spec > SRPM URL: > https://marcindulak.fedorapeople.org/packages/quantum-espresso/r02/quantum- > espresso-5.2.1-1.el6.src.rpm I'll try to review this later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review