[Bug 1287120] Review Request: python-ryu - component-based Software-defined Networking Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1287120



--- Comment #7 from Arie Bregman <abregman@xxxxxxxxxx> ---
Updated:

Spec URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-ryu.spec
SRPM URL:
https://bitbucket.org/abregman/bregman-rpms/downloads/python-ryu-3.26-1.el7.src.rpm

@Robert:

- In %prep, why are you removing requirements files?
According to Haikel review: "I'd remove *requirements files to prevent pbr
downloading stuff" 

- There is no man-page
not sure I'm following. what should I do about it?

- Is there a reason you're not using %py2_install / %py2_install ? 
it's not working for me. seems like it can't find such macro.

- In %build, you could simply use %py2_build / %py3_build
same here

- Description "This is Python 3 version." could probably us an article.
what do you mean?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]