https://bugzilla.redhat.com/show_bug.cgi?id=1287120 Robert Buchholz <rhbugs@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhbugs@xxxxxx --- Comment #6 from Robert Buchholz <rhbugs@xxxxxx> --- - Url: has double http:// in front. It should point to the https variant too. [1] - You are not building for python3 (with_python3 is not defined) - The package must provide python2-ryu, and this must be a subpackage if you are building for python3 as well. - Several dependencies are downloaded during testing. Since they are required, they should also be listed as BuildRequires. - Description "This is Python 3 version." could probably us an article. - In %prep, why are you removing requirements files? - In %build, you could simply use %py2_build / %py3_build - Is there a reason you're not using %py2_install / %py2_install ? They introduce an -O1 that you are missing, is that relevant? - I think AUTHORS and ChangeLog should be %doc - There are no files directives for python3 - There is no man-page - Tests are currently failing for me: Traceback (most recent call last): File "/builddir/build/BUILD/ryu-3.26/.eggs/pbr-1.8.1-py2.7.egg/pbr/core.py", line 109, in pbr attrs = util.cfg_to_args(path) File "/builddir/build/BUILD/ryu-3.26/.eggs/pbr-1.8.1-py2.7.egg/pbr/util.py", line 245, in cfg_to_args kwargs = setup_cfg_to_setup_kwargs(config) File "/builddir/build/BUILD/ryu-3.26/.eggs/pbr-1.8.1-py2.7.egg/pbr/util.py", line 379, in setup_cfg_to_setup_kwargs cmd = cls(dist) File "/usr/lib/python2.7/site-packages/setuptools/__init__.py", line 131, in __init__ _Command.__init__(self, dist) File "/usr/lib64/python2.7/distutils/cmd.py", line 59, in __init__ raise TypeError, "dist must be a Distribution instance" TypeError: dist must be a Distribution instance [1] Hopefully they merge https://github.com/osrg/ryu/pull/44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review