[Bug 1288453] Review Request: python-CommonMark - Python parser for the CommonMark Markdown spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1288453



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
The point of the -doc subpackage is to avoid duplication to save disk space. It
also saves user confusion, because the don't have to look at python2-*-doc
first, and then at python3-*-doc first, and realize that the documentation is
identical. Files in python2-CommonMark-doc and python2-CommonMark-doc *are*
identical, there should be just one -doc package.

You can avoid defining %sum. Just put the summary in the first Summary, and
then use %summary in subsequent subpackages. The summary for -doc should be
different though.

Please use %{__python3} to refer to /usr/bin/python3 everywhere in the spec
file.

You probably don't need to use sed to fix the shebang line. Just move
%py2_install below %py3_install.

PYTHONPATH=$(pwd):$PYTHONPATH → PYTHONPATH=$(pwd)
PYTHONPATH is normally unset, so you don't need to preserve the previous one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]