https://bugzilla.redhat.com/show_bug.cgi?id=1287193 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #19 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- - license is OK - license file is present, %license is used - latest version - uses the new python packaging template - requires and provides look ok - no scriptlets - builds, install, runs fine - rpmlint: letsencrypt.noarch: W: spurious-executable-perm /usr/share/man/man1/letsencrypt-renewer.1.gz letsencrypt.noarch: W: spurious-executable-perm /usr/share/man/man1/letsencrypt.1.gz Please remove executable bit. letsencrypt-doc.noarch: W: spurious-executable-perm /usr/share/man/man7/letsencrypt.7.gz There's no need for this file to be in doc subpackage too. letsencrypt.noarch: E: non-readable /etc/letsencrypt 0 This dir is %ghosted, seems to be a bug in rpmlint. letsencrypt.src:60: W: unversioned-explicit-provides bundled(jquery) letsencrypt.src:61: W: unversioned-explicit-provides bundled(underscore) letsencrypt.src:62: W: unversioned-explicit-provides bundled(inconsolata-fonts) letsencrypt.src:63: W: unversioned-explicit-provides bundled(lato-fonts) letsencrypt.src:64: W: unversioned-explicit-provides bundled(robotoslab-fonts) You should add versions... Probably matters the most for jquery and underscore, the rest can be ignored. letsencrypt-doc.noarch: W: dangling-symlink /usr/share/doc/letsencrypt-doc/html/_static/fonts/fontawesome-webfont.eot /usr/share/fonts/fontawesome/fontawesome-webfont.eot letsencrypt-doc.noarch: W: dangling-symlink /usr/share/doc/letsencrypt-doc/html/_static/fonts/fontawesome-webfont.svg /usr/share/fonts/fontawesome/fontawesome-webfont.svg letsencrypt-doc.noarch: W: dangling-symlink /usr/share/doc/letsencrypt-doc/html/_static/fonts/fontawesome-webfont.ttf /usr/share/fonts/fontawesome/fontawesome-webfont.ttf letsencrypt-doc.noarch: W: dangling-symlink /usr/share/doc/letsencrypt-doc/html/_static/fonts/fontawesome-webfont.woff /usr/share/fonts/fontawesome/fontawesome-webfont.woff Those are actually fine when installed. python2-letsencrypt.noarch: W: no-documentation python2-letsencrypt.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/letsencrypt/tests/testdata/cert-san.pem python2-letsencrypt.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/letsencrypt/tests/testdata/cert.pem python2-letsencrypt.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/letsencrypt/tests/testdata/dsa_cert.pem python2-letsencrypt.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/letsencrypt/tests/testdata/matching_cert.pem 4 packages and 0 specfiles checked; 1 errors, 17 warnings. Those are obviously used for testing, so that's all fine. Please fix up the small issues pointed out above when uploading. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review