https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #10 from Carl George <carl.george@xxxxxxxxxxxxx> --- I haven't done a formal package review before, but I'm happy to learn. Based on the docs [1] "any Fedora account holder who is a member of the packager group" can do it, so I think I'm good permissions-wise. I'll go ahead and give some initial feedback that I noticed in the spec file. 1. BuildRoot isn't needed for EL6+, so it can be removed. 2. %clean section isn't needed for EL6+, so it can be removed. 3. %defattr lines in each %files section are only needed if permissions differ from default, so they can be removed. [1]: https://fedoraproject.org/wiki/Package_Review_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review