https://bugzilla.redhat.com/show_bug.cgi?id=1281876 Bug ID: 1281876 Summary: Review Request: enki - Extensible text editor for programmers Product: Fedora Version: rawhide Component: Package Review Keywords: FutureFeature Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: projects.rg@xxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: anto.trande@xxxxxxxxx, extras-qa@xxxxxxxxxxxxxxxxx, i@xxxxxxxx, kevin@xxxxxxxxxxxxxxxx, nobody@xxxxxxxxxxxxxxxxx, package-review@xxxxxxxxxxxxxxxxxxxxxxx, projects.rg@xxxxxxxx, tchollingsworth@xxxxxxxxx, yajo.sk8@xxxxxxxxx Depends On: 984560 (enki), 1273601 (python-qutepart) Blocks: 177841 (FE-NEEDSPONSOR), 928937 (qt-reviews) SPEC: https://raphgro.fedorapeople.org/review/qt/enki/enki.spec SRPM: https://raphgro.fedorapeople.org/review/qt/enki/enki-15.05.0-1.src.rpm Description: Extensible text editor for programmers FAS user name: raphgro Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11821962 I take over and continue from the original review request of Yajo. +++ This bug was initially created as a clone of Bug #984560 +++ Spec URL: https://build.opensuse.org/package/view_file/home:yajo:enki/enki?expand=1&file=enki.spec SRPM URL: http://download.opensuse.org/repositories/home:/yajo:/enki/Fedora_19/src/enki-12.10.3-4.1.src.rpm Description: Text editor for programmers. Enki is: - User friendly. Intuitive interface. Works out of the box. You don’t have to read a lot of docs - Hacker friendly. Code as quickly as possible. Without mouse. - Lighweight. Some IDEs show splash screen. Enki will never do it. It just starts quickly. - Extensible. Operating systems are designed for running applications. Enki is designed for running plugins. - Cross platform. Use your habitual editor on any OS. Currently has been tested on Linux, MacOS X, Windows. - High quality. No long list of fancy features. But, what is done, is done well. - Open source. This is our religion. This is my first package for fedora and I need someone to sponsor. --- Additional comment from Christopher Meng on 2013-07-15 15:58:12 CEST --- Hey, 1. Can you build your spec under Fedora instead of OBS? 2. Have you read the guidelines? - You shouldn't use define to create a custom macro, please use global; - Your BuildRequires are wrong, please fix. Like setuptools, you shouldn't use development package. And python version in Fedora doesnt have 2.6.6, please, use Fedora to test. - You have desktop files installed, but you don't validate it. Please use desktop-file-utils to validate. - You have icons installed, please update the cache. - Your source0 tag is missing, however source is ok. But its syntax is wrong again. For more details of fixing, please read our guidelines. And a friendly note, please do not use OBS to build RPM for Fedora. --- Additional comment from Antonio Trande on 2013-07-15 15:59:32 CEST --- Hi Yajo. Please, add a briefly description of package in the review summary, too. See this example: http://fedoraproject.org/wiki/File:PackageReviewProcess_review.png It would be better add a comment about included patch. See http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment You need a validate task of the '.desktop' file. http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files --- Additional comment from Yajo on 2013-07-17 07:25:56 CEST --- (In reply to Christopher Meng from comment #1) > 1. Can you build your spec under Fedora instead of OBS? Of course. I built it there before uploading. > 2. Have you read the guidelines? > > [...] Yes, I did. However sorry for my newbieness. All you said is fixed now. > And a friendly note, please do not use OBS to build RPM for Fedora. I found it very practical. Is there any recommended similar service? This time I uploaded everything to the closed-source Google Drive. I hope people like it. (In reply to Antonio Trande from comment #2) > Hi Yajo. > > Please, add a briefly description of package in the review summary, too. > See this example: > http://fedoraproject.org/wiki/File:PackageReviewProcess_review.png > > It would be better add a comment about included patch. > See > http://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > > You need a validate task of the '.desktop' file. > http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files All done, thanks. New SPEC: https://docs.google.com/file/d/0B6L4jqW88ytdamlWdS0zZHR6SjA/edit?usp=sharing New SRPM: https://docs.google.com/file/d/0B6L4jqW88ytdNzJ0dEQ4b0NDUlk/edit?usp=sharing --- Additional comment from Yajo on 2013-10-06 13:45:35 CEST --- New SPEC: https://build.opensuse.org/package/view_file/home:yajo:enki/enki/enki.spec?expand=1 New SRPM: http://download.opensuse.org/repositories/home:/yajo:/enki/Fedora_19/src/enki-13.09.2-5.1.src.rpm Sorry for using OBS. It's just a way to upload the files. Build has been tested in Fedora with mock first. Thanks. --- Additional comment from T.C. Hollingsworth on 2013-10-28 01:03:08 CET --- (In reply to Yajo from comment #4) > New SPEC: > https://build.opensuse.org/package/view_file/home:yajo:enki/enki/enki. > spec?expand=1 HTML again. ;-) -- > %global _iconsbasedir %{?_iconsbasedir:/usr/share/icons/hicolor} > %global _desktopdir %{?_desktopdir:/usr/share/applications} Please don't hardcode /usr. Use the appropriate macro for /usr/share instead: http://fedoraproject.org/wiki/Packaging:RPMMacros > BuildRequires Please add BuildRequires on python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires The -devel subpackage makes available certain RPM macros and may enable other magic in the future, so it needs to be explictly BuildRequired from every python spec file. > %{_datarootdir}/pixmaps/%{name}.png Please use %{_datadir} instead. The GNU coding standards explain the subtle distinction between these two: https://www.gnu.org/prep/standards/html_node/Directory-Variables.html --- Additional comment from Yajo on 2014-07-07 18:55:10 CEST --- (In reply to T.C. Hollingsworth from comment #5) All fixed. As always, thanks for the interesting info there, it's a pleasure to learn. New SRPM: http://download.opensuse.org/repositories/home:/yajo:/enki/Fedora_20/src/enki-14.03.0-7.1.src.rpm New SPEC: https://build.opensuse.org/source/home:yajo:enki/enki/enki.spec?rev=88e30c8eee4422f224fc25735354d954 Cannot paste koji link until python-qutepart is approved. Thanks for all! --- Additional comment from Fedora End Of Life on 2015-01-09 19:55:47 CET --- This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. --- Additional comment from Raphael Groner on 2015-05-01 11:16:39 CEST --- Sorry, I can not see why this review depends on another one. --- Additional comment from Raphael Groner on 2015-05-01 11:24:45 CEST --- Would you mind to build with Qt5? Well, upstream suggests PyQt4 as a dependency, maybe it buikds also with PyQt5. --- Additional comment from Yajo on 2015-05-02 13:49:23 CEST --- (In reply to Raphael Groner from comment #9) > Would you mind to build with Qt5? Well, upstream suggests PyQt4 as a > dependency, maybe it buikds also with PyQt5. Not until https://github.com/hlamer/qutepart/issues/21 gets fixed. --- Additional comment from Yajo on 2015-05-07 17:49:30 CEST --- Enki got updated. SPEC URL: https://build.opensuse.org/source/home:yajo:enki/enki/enki.spec?rev=fab59e6ab419feb6f9c436162b717e0b SRPM URL: http://download.opensuse.org/repositories/home:/yajo:/enki/Fedora_21/src/enki-15.04.0-9.1.src.rpm I removed the Spanish descriptions because I think those will work better with AppData. --- Additional comment from Raphael Groner on 2015-05-31 20:32:51 CEST --- Is it possible to get it done with PyQt5 (package name for dependency: python-qt5) ? --- Additional comment from Yajo on 2015-06-02 09:15:39 CEST --- This depends on python-qutepart, so I guess https://bugzilla.redhat.com/show_bug.cgi?id=1015868#c24 also applies here. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=984560 [Bug 984560] Review Request: enki - Extensible text editor for programmers https://bugzilla.redhat.com/show_bug.cgi?id=1273601 [Bug 1273601] Review Request: python-qutepart - Code editor widget -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review
