[Bug 1240122] Review Request: mysema-apt-maven-plugin - Maven APT plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1240122



--- Comment #11 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Raphael Groner from comment #10)
> Taken. :)
> 
> Informal advice first before an official review process:
> 
> - Please remove one 'provides' from %description. 

Done

> - You could shorten Source0: value with usage of the %{url} placeholder.
Sorry, I'd rather not

> - Please explain the following command line, what is native2ascii (comment!)
>   and what package contains that command? Is it about conversion of line
> feeds?
Done 
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-
> encoding
> > native2ascii -encoding UTF8 src/main/java/com/mysema/maven/apt/FileSync.java \
>  src/main/java/com/mysema/maven/apt/FileSync.java

Add comment, native2ascii is a JDK tool I use to convert non non ASCII chars

> - How to run the dedicated tests in src/test folder?
Sorry, I dont understand the question. Maven build stile is different from Ant
test suite are runnig in the same "place", %%check section is unnecessary.

Spec URL: https://gil.fedorapeople.org/mysema-apt-maven-plugin.spec
SRPM URL:
https://gil.fedorapeople.org/mysema-apt-maven-plugin-1.1.3-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]