[Bug 1240122] Review Request: mysema-apt-maven-plugin - Maven APT plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1240122

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |projects.rg@xxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |projects.rg@xxxxxxxx
              Flags|                            |fedora-review?



--- Comment #10 from Raphael Groner <projects.rg@xxxxxxxx> ---
Taken. :)

Informal advice first before an official review process:

- Please remove one 'provides' from %description. 

- You could shorten Source0: value with usage of the %{url} placeholder.

- Please explain the following command line, what is native2ascii (comment!)
  and what package contains that command? Is it about conversion of line feeds?
 
https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding
> native2ascii -encoding UTF8 src/main/java/com/mysema/maven/apt/FileSync.java \
 src/main/java/com/mysema/maven/apt/FileSync.java

- How to run the dedicated tests in src/test folder?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]