https://bugzilla.redhat.com/show_bug.cgi?id=1258274 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Good: - rpmlint checks return: glassfish-jaxrpc-api.src: W: invalid-url Source0: glassfish-jaxrpc-api-1.1.1.tar.xz glassfish-jaxrpc-api.noarch: W: no-documentation All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (manual check okay) - package compiles on f23 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - javadoc ok - nothing in %doc affects runtime - no need for .desktop file License tag needs to be fixed before import. pom.xml confirms that proper tag is CDDL or GPLv2 with exceptions (your current spec has "and"). APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review