https://bugzilla.redhat.com/show_bug.cgi?id=995444 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %license, matches source - spec file legible, in am. english - source matches upstream (30944ba6a3826f39259279df7b90a3f0df41d47e9fd48fbc28c1feef13ea39fe) - package compiles on f23 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - javadoc ok - nothing in %doc affects runtime - no need for .desktop file One minor issue here. The license should be: CDDL or GPLv2 with exceptions but your tag has: CDDL and GPLv2 with exceptions Please fix that before import. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review