[Bug 1274645] Review Request: python-faker - Faker is a Python package that generates fake data for you

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1274645



--- Comment #7 from Juan Orti <j.orti.alcaine@xxxxxxxxx> ---
(In reply to William Moreno from comment #6)
> Good job building the doc, please note:
> 
> The man page must be in the same package of the executable under %{_bindir},
> the idea is to have the manpage available to get info about a command
> without the need of install aditional packages.

Now I install the man page for both executables.

> Move the docs/_build/html and docs/_build/text directoriies to the top of
> your BuildRoot with mv.
> 
> pushd docs
> PYTHONPATH='..' %make_build html
> PYTHONPATH='..' %make_build text
> PYTHONPATH='..' %make_build man
> find . -type f -name '.buildinfo' -delete
> mv _build/html ../
> mv _build/text ../
> popd

I don't think this is necessary, as %doc copies the content to the %_docdir
with the same result as your suggestion:

$ rpmls python-faker-doc-0.5.3-4.fc23.noarch.rpm | head
drwxr-xr-x  /usr/share/doc/python-faker-doc
-rw-r--r--  /usr/share/doc/python-faker-doc/CHANGELOG.rst
-rw-r--r--  /usr/share/doc/python-faker-doc/CONTRIBUTING.rst
-rw-r--r--  /usr/share/doc/python-faker-doc/README.rst
drwxr-xr-x  /usr/share/doc/python-faker-doc/html
drwxr-xr-x  /usr/share/doc/python-faker-doc/html/_sources
-rw-r--r--  /usr/share/doc/python-faker-doc/html/_sources/coding_style.txt
-rw-r--r--  /usr/share/doc/python-faker-doc/html/_sources/index.txt
drwxr-xr-x  /usr/share/doc/python-faker-doc/html/_sources/locales
-rw-r--r--  /usr/share/doc/python-faker-doc/html/_sources/locales.txt


> You are duplicanting files this files: README.rst CHANGELOG.rst
> CONTRIBUTING.rst

Moved to the doc package.


> With have weak depencies in Fedora, in booth python2 and python3 packages
> include:
> 
> Enhances: %{name}-doc%{?_isa} = %{version}-%{release}

Enhances should be in the doc package, right? Anyway, I have chosen to use the
Suggests tag.

> Will be nice to run the test in the packaging process but I will no block
> this review for that, just inclue the %%check section in the spec with a
> link to the issue in github.

Ok, I have left it commented.

> 
> Remember than if you change the source from github to pypi you will need to
> remove the blunded egg.info in prep.

Ok.


Spec URL: https://jorti.fedorapeople.org/python-faker/python-faker.spec
SRPM URL:
https://jorti.fedorapeople.org/python-faker/python-faker-0.5.3-4.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]