[Bug 1274645] Review Request: python-faker - Faker is a Python package that generates fake data for you

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1274645



--- Comment #6 from William Moreno <williamjmorenor@xxxxxxxxx> ---
Good job building the doc, please note:

The man page must be in the same package of the executable under %{_bindir},
the idea is to have the manpage available to get info about a command without
the need of install aditional packages.

Move the docs/_build/html and docs/_build/text directoriies to the top of your
BuildRoot with mv.

pushd docs
PYTHONPATH='..' %make_build html
PYTHONPATH='..' %make_build text
PYTHONPATH='..' %make_build man
find . -type f -name '.buildinfo' -delete
mv _build/html ../
mv _build/text ../
popd

You are duplicanting files this files: README.rst CHANGELOG.rst
CONTRIBUTING.rst

You can leave the doc subpackage with just:

%files doc
%doc html text

The license file with be instaled with the python2 or python3 rpm so the doc
subpackage do not need to ship the license file.

With have weak depencies in Fedora, in booth python2 and python3 packages
include:

Enhances: %{name}-doc%{?_isa} = %{version}-%{release}

Will be nice to run the test in the packaging process but I will no block this
review for that, just inclue the %%check section in the spec with a link to the
issue in github.

Remember than if you change the source from github to pypi you will need to
remove the blunded egg.info in prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]