https://bugzilla.redhat.com/show_bug.cgi?id=1268716 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #5 from Christopher Meng <i@xxxxxxxx> --- Good to see this got packaged by someone else, I tried to package it 1 year ago, it actually sucked a lot, all nodejs to native suck. 1. Bundled nacl and libuv are still issues, that's the main point why it sucks IMO. 2. You shouldn't put files under libdir/cjdns, use libexec instead. 3. %defattr(-,root,root,-) rm -rf $RPM_BUILD_ROOT Drop them. 4. Read https://fedoraproject.org/wiki/Packaging:SysVInitScript and see how to handle init files. 5. /usr/sbin/useradd -g cjdns -c "IPv6 VPN" "IPv6 VPN" is not enough. == Small issues == %if 0%{?rhel} == 6 /%{_sysconfdir}/init/* -> %{_sysconfdir}/init/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review