https://bugzilla.redhat.com/show_bug.cgi?id=1107127 --- Comment #20 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Orion Poplawski from comment #19) > So, I'm assuming you guys are interested in co-maintaining? Who is going to > be the POC? James, since he wrote it, though it's currently moot. I don't specifically want to maintain it, but I'd like to see it available as an answer to "Why does my program fail under the batch system?". > James - > > - No need for %defattr(), please remove I'd subsequently done that and modified the perl-JSON-PP condition per the previous comment. (I think this preceded EPEL7.) Is it still relevant with whatever "check" does? # Only used for testing; not in EPEL < 7. %if 0%{?fedora} || 0%{rhel} > 6 BuildRequires: perl-JSON-PP %endif > - Why are you running autoreconf? It no longer ships with autotools output, though I think it should. (I realize you may not want to keep that in the repo, and I assume you'd have to when using github, but omitting it probably makes builds less reliable.) In their absence, I'd have run the "reconf" script that's there. The packaging rules say the source URL should be of the form https://github.com/jamesodhunt/procenv/archive/%commit.tar.gz and then you need %setup -q -n procenv-%commit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review