https://bugzilla.redhat.com/show_bug.cgi?id=1272652 --- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Jerry James from comment #7) > Issues: > ======= > 1. The existence of -fomit-frame-pointer in tclconfig/tcl.m4 concerns me a > little. Maybe it doesn't matter, as I believe that is the default on > x86_64 > these days anyway, but I'm not sure that it is the default (and won't harm > the quality of the debuginfo) on other architectures. What do you think > about removing that? Removed; it's turned on with -O2 optimization but disabled: $ gcc -c -Q -O2 --help=optimizers | grep fomit -fomit-frame-pointer [disabled] > > 2. The tests fail on x86_64, but the %check script doesn't notice. Please > make %check fail if the tests fail, then figure out why the tests are > failing. It looks trivial: "bad relief" versus "bad relief type". I'm > more concerned that %check succeeded anyway. Yes, i know; i have signaled to upstream but still none reply. http://sourceforge.net/p/tktable/mailman/tktable-users/?viewmonth=201510 Those two tests do not fail in EPEL. > > 3. Since a python source file is included in the package, it should > BuildRequires: python2-devel or python3-devel as appropriate. > > 4. Speaking of the python file, should it really be in > %{_libdir}/tcl8.6/Tktable2.10, or should it be installed where python > files > usually go? It's a wrapper for Python2; i have packaged as a python sub-package. > > 5. html/tkTable.html and README.txt are in both %{_libdir}/tcl8.6/Tktable2.10 > and /usr/share/doc/tktable. Does they need to be both places? > > 6. Similarly, license.txt is in both %{_libdir}/tcl8.6/Tktable2.10 and in > /usr/share/licenses/tktable. Does it need to be both places? > Fixed. Thanks. Spec URL: https://sagitter.fedorapeople.org/tktable/tktable.spec SRPM URL: https://sagitter.fedorapeople.org/tktable/tktable-2.10-6.fc22.src.rpm - Remove duplicated documentation - Install python wrapper - Remove potentially bad flag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review