https://bugzilla.redhat.com/show_bug.cgi?id=1272652 --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= 1. The existence of -fomit-frame-pointer in tclconfig/tcl.m4 concerns me a little. Maybe it doesn't matter, as I believe that is the default on x86_64 these days anyway, but I'm not sure that it is the default (and won't harm the quality of the debuginfo) on other architectures. What do you think about removing that? 2. The tests fail on x86_64, but the %check script doesn't notice. Please make %check fail if the tests fail, then figure out why the tests are failing. It looks trivial: "bad relief" versus "bad relief type". I'm more concerned that %check succeeded anyway. 3. Since a python source file is included in the package, it should BuildRequires: python2-devel or python3-devel as appropriate. 4. Speaking of the python file, should it really be in %{_libdir}/tcl8.6/Tktable2.10, or should it be installed where python files usually go? 5. html/tkTable.html and README.txt are in both %{_libdir}/tcl8.6/Tktable2.10 and /usr/share/doc/tktable. Does they need to be both places? 6. Similarly, license.txt is in both %{_libdir}/tcl8.6/Tktable2.10 and in /usr/share/licenses/tktable. Does it need to be both places? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 143360 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Buildroot is not present This is needed for EPEL 5 support. Later releases don't need it. [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Ditto: needed for EPEL 5 support. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tktable-2.10-5.fc24.x86_64.rpm tktable-2.10-5.fc24.src.rpm tktable.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti tktable.x86_64: W: spelling-error %description -l en_US resizable -> re sizable, re-sizable, recognizable tktable.x86_64: W: spelling-error %description -l en_US scrollbar -> scroll bar, scroll-bar, scroll tktable.src: W: spelling-error %description -l en_US multi -> mulch, mufti tktable.src: W: spelling-error %description -l en_US resizable -> re sizable, re-sizable, recognizable tktable.src: W: spelling-error %description -l en_US scrollbar -> scroll bar, scroll-bar, scroll 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: tktable-debuginfo-2.10-5.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- tktable (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) tcl(abi) tk Provides -------- tktable: libTktable2.10.so()(64bit) tktable tktable(x86-64) Unversioned so-files -------------------- tktable: /usr/lib64/tcl8.6/Tktable2.10/libTktable2.10.so Source checksums ---------------- http://download.sourceforge.net/tktable/Tktable2.10.tar.gz : CHECKSUM(SHA256) this package : c335117fa1be45fe4d3032e96fd4b4641fff6a4f8467878608dabed11198a4cb CHECKSUM(SHA256) upstream package : c335117fa1be45fe4d3032e96fd4b4641fff6a4f8467878608dabed11198a4cb Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1272652 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review