https://bugzilla.redhat.com/show_bug.cgi?id=1272187 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- I'm pretty sure I clicked on the link from this review ticket. Anyway, it's up to date now. I just looked at the python packaging guidelines (https://fedoraproject.org/wiki/Packaging:Python) and it looks like the python package boilerplate has changed since I last looked at a python package, with a view to making Python 3 the default python somewhere down the line. Given that I don't think you're targeting anything older than F-23 with this package, I'd suggest using the modern packaging style: * Use python2-* dependencies rather than python-* dependencies where possible (currently python-httplib2, python-oauth2client and python-uri-templates don't have the necessary provides for this as yet, which should get fixed really) * Rename the python-google-api-client package to python2-google-api-client * Use the %python_provide macro as per the guidelines and sample spec * Use %py2_build, %py3_build, %py2_install and %py3_install as per the sample spec Again, if you're only targeting F-23 onwards, you can dispense with the python3 build conditional and just do it unconditionally, which would simplify the spec quite a bit. Or do you have thoughts of supporting EPEL-7 perhaps? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review