https://bugzilla.redhat.com/show_bug.cgi?id=1272187 Michele Baldessari <michele@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michele@xxxxxxxxxx --- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> --- Thanks Paul, could it be that you took a look at some older packages? The ones in the description had most of the comments fixed. (In reply to Paul Howarth from comment #1) > Some initial comments prior to a formal review: > > * Current upstream version is 1.4.2, not 1.4.1 Done (see above) > * I'd suggest replicating the runtime Requires: as BuildRequires: > That way, not only should any future test suite run OK, but you'll > find out at build-time rather than install-time if there are any > dependency issues. Ack, agreed > * Version requirements from setup.py are not reflected in rpm deps. Done (see above) > * Dependency on python-six is missing. Done (see above) > * Comment referring to BZ 1205170 can probably be dropped. Done (see above) > * Shellbang removal should be done in %prep rather than %install; if > done before the copy to %{py3dir}, it can be done just once. Nice catch, fixed > * Typo in comment for 1.4.0-1: pythn3 missing "o". Done (see above) Thanks for the feedback, Paul! New packages: Spec URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client.spec SRPM URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client-1.4.2-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review