[Bug 1264985] Review Request: nodejs-es6-promise - Lightweight library that provides tools for organizing asynchronous code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264985



--- Comment #3 from Troy Dawson <tdawson@xxxxxxxxxx> ---
Spec URL: https://tdawson.fedorapeople.org/nodejs/nodejs-es6-promise.spec
SRPM URL:
https://tdawson.fedorapeople.org/nodejs/nodejs-es6-promise-3.0.2-2.fc24.src.rpm

- Added "%nodejs_symlink_deps" macro to the %install section
- Switched LICENSE from %doc to %license
-- Thanks for the tip about making it compatible with EL6
- Added the test suite
-- I was not able to get the test suite to run due to dependencies.
--- nodejs-ember-cli has a naming conflict with ember the game.  Plus it's not
a typical straight forward npm install.
--- It's dependency list is crazy long too.
-- When I manually added the dependencies, I still could not get it to run. 
The ember-cli stuff had instructions on where to put links and stuff to fix the
problems, but I really wasn't comfortable putting that into an rpm, when we
don't even have the dependencies in yet.
-- Disabled the tests for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]