https://bugzilla.redhat.com/show_bug.cgi?id=1264985 --- Comment #2 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- Just a couple of quick comments before I do the formal review: * You should call the "%nodejs_symlink_deps" macro in the %install section * In the %files section, the LICENSE file should go in %license. To be backwards compatible with EL6, I'd do someting like this: %files %{!?_licensedir:%global license %doc} %doc CHANGELOG.md README.md %license LICENSE %{nodejs_sitelib}/%{npm_name} * You should call the test suite, if there is one. See https://jsmith.fedorapeople.org/Packaging/nodejs-deeper/nodejs-deeper.spec as an example of how I extract the tests from the upstream GitHub repo, as the npm tarballs typically don't have the tests included. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review