https://bugzilla.redhat.com/show_bug.cgi?id=1271582 --- Comment #3 from Vratislav Podzimek <vpodzime@xxxxxxxxxx> --- (In reply to Šimon Lukašík from comment #2) > Issues: > ======= > - Please raise release number each time you update new specfile and srpm I don't see a point in this. I'm not doing releases. I'm just getting to the first release. > - Your upstream URL points to https://github.com/vpodzime/libbytesize/ > I think it should point out to https://github.com/rhinstaller/libbytesize > The latter location has more up-todate sources and the former is just an > outdated fork Oh, I forgot that by doing my own fork, GH stopped redirecting the original URL to the new one. Fixing. > - Could not found: > https://github.com/vpodzime/libbytesize/archive/libbytesize-0.1.tar.gz > Please release upstream before I grant the fedora-review+ Sure will do when other things are addressed. I want the first release to really be the first released one. I don't want to force-push the tag. > - No documentation included. Please put upstream's README.rst into the base > package. Sounds good, fixing. > - Python sub-packages should require the base package, or does it work > without > the lib? Good point, fixing. > - Please consider naming python sub-packages python-bytesize instead of > python-libbytesize. I don't know the right answer here. Just think about > this and let me know. I don't know the right answer either, but python-bytesize sounds better to me. Changing. > - Fix rpmlint issue: > libbytesize.x86_64: W: summary-ended-with-dot C A library for working with > sizes in bytes. Alright, alright. > - Aren't here missing dependencies in python sub-packages? > I would thing that python3-gobject and pygobject3-base should be required. > But I may be wrong, you certainly have more gobject experience. ;-) You are right, those are needed. :) > - Similarly, there are directories without owners, in the packages. > Please review them and see if you can solve this somehow (my suggestion > is to add a dependency. > * /usr/share/gir-1.0 (-> libbytesize-devel should require GConf2-devel) Why GConf2-devel? Here's what I have no my system: # rpm -qf /usr/share/gir-1.0 atk-devel-2.14.0-1.fc21.x86_64 libxklavier-devel-5.4-4.fc21.x86_64 gobject-introspection-devel-1.42.0-1.fc21.x86_64 libgee-devel-0.16.1-1.fc21.x86_64 gtk2-devel-2.24.28-1.fc21.x86_64 vte3-devel-0.36.3-3.fc21.x86_64 gtk3-devel-3.14.15-1.fc21.x86_64 gdk-pixbuf2-devel-2.31.6-1.fc21.x86_64 >From those, I think gobject-introspection-devel makes most sense. Adding that. > * /usr/lib64/girepository-1.0 (-> libbytesize should require > gobject-introspection) Yes, adding it. > > This is complete list of issues, I have been able to identify today. > Overall good job! Thanks! All of the above should be addressed in the current version of the spec and SRPM (same URLs). I also changed the licence of the package (and upstream) to LGPLv2+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review