https://bugzilla.redhat.com/show_bug.cgi?id=1271582 --- Comment #2 from Šimon Lukašík <slukasik@xxxxxxxxxx> --- Issues: ======= - Please raise release number each time you update new specfile and srpm - Your upstream URL points to https://github.com/vpodzime/libbytesize/ I think it should point out to https://github.com/rhinstaller/libbytesize The latter location has more up-todate sources and the former is just an outdated fork - Could not found: https://github.com/vpodzime/libbytesize/archive/libbytesize-0.1.tar.gz Please release upstream before I grant the fedora-review+ - No documentation included. Please put upstream's README.rst into the base package. - Python sub-packages should require the base package, or does it work without the lib? - Please consider naming python sub-packages python-bytesize instead of python-libbytesize. I don't know the right answer here. Just think about this and let me know. - Fix rpmlint issue: libbytesize.x86_64: W: summary-ended-with-dot C A library for working with sizes in bytes. - Aren't here missing dependencies in python sub-packages? I would thing that python3-gobject and pygobject3-base should be required. But I may be wrong, you certainly have more gobject experience. ;-) - Similarly, there are directories without owners, in the packages. Please review them and see if you can solve this somehow (my suggestion is to add a dependency. * /usr/share/gir-1.0 (-> libbytesize-devel should require GConf2-devel) * /usr/lib64/girepository-1.0 (-> libbytesize should require gobject-introspection) This is complete list of issues, I have been able to identify today. Overall good job! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review