https://bugzilla.redhat.com/show_bug.cgi?id=1268010 --- Comment #3 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Dominique Martinet from comment #2) > Hmm I'll admit I didn't even try to build on EPEL5, will remove it. Group does no harm, but some reviewers object to it being there. > Right, will fix. > I think I do need to keep the devel package requirements on other -devel > packages, though, right? > As far as I can tell (rpm -qpi --requires <package>) it could not guess > these, and I couldn't find anything in the guidelines about this. Yes, I looked without success, and it's quite inconsistent in packages generally. I'd have thought the dependencies should be added, but it's difficult to verify them (and I don't know why rpmbuild doesn't try to follow #includes). > Hmm I wonder why I added the .la there, if anything it should have been in > the -devel... But right rhel systems don't even have it, will remove. That's something that is in the guidelines. (I sympathize with "I wonder why I ..."!) > No problem, thanks for the review! It's only an informal one. I hope someone (Red Hat storage?) can test it, as required for a proper review, and sponsor you. They probably expect to see more packaging and/or informal reviews of other things, first. If you have any more to contribute, even if it's not ready or appropriate for review, I'd recommend setting up a copr repo. Most of what I install on our cluster goes into mine. > I'll fix all of that and try > fedora-review as soon as I get my laptop back home (might be a few days, > will update the ticket with new URLs anyway) > Our development servers are behind a kerberized proxy and the fedora tools > can't seem to work with that, unfortunately :/ I don't know what it needs that would be blocked, but you can run fedora-review on local package source, which is what I meant. I've only managed to do that in a rawhide vagrant box, though, which is more painful than I'd like. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review